Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update manual and arrow tutorial for new semantics of lc w.r.t arrows #40

Merged
merged 2 commits into from
Nov 14, 2013

Conversation

byorgey
Copy link
Member

@byorgey byorgey commented Nov 13, 2013

The styles of the head, tail and shaft may be individually overridden
using `headStyle`, `tailStyle`, and `shaftStyle`. We change the
attributes of the arrow parts by setting one of these parameters equal
to a function that applies the attributes, *e.g.* `headStyle = fc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated to reflect lenses and the change of field type. Eg, headStyle %~ fc blue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, there's lots of that sort of thing that needs updating (much more than just this sentence). I thought I would leave that to another day.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough.

@bergey
Copy link
Member

bergey commented Nov 14, 2013

Do you know why the travis build failed?

@byorgey
Copy link
Member Author

byorgey commented Nov 14, 2013

Whoops, thanks, I missed that. I'm headed to bed now, feel free to fix it, or I will in the morning.

The travis build is failing for some unrelated reason... something screwy going on with the Shake build system.

@bergey
Copy link
Member

bergey commented Nov 14, 2013

Travis mysteriously fixed itself. Good enough for me.

bergey added a commit that referenced this pull request Nov 14, 2013
update manual and arrow tutorial for new semantics of lc w.r.t arrows
@bergey bergey merged commit 05d9dfb into master Nov 14, 2013
@byorgey
Copy link
Member Author

byorgey commented Nov 14, 2013

You know, I think I've seen this error (about web/doc not getting created) locally as well. My current theory is that it is some sort of race condition, where shake checks for the existence of some directory before it is actually created (but it would have been if shake had waited a tad longer before checking). Not sure if it's shake's fault or ours.

@byorgey byorgey deleted the delayed-subtrees branch November 14, 2013 11:35
@jeffreyrosenbluth
Copy link
Member

I think I'm having the same problem, trying to build to docs after replacing a subdirectory

@byorgey
Copy link
Member Author

byorgey commented Nov 14, 2013

@jeffreyrosenbluth: Usually for me the problem goes away if I just run Shake a second time (without cleaning in between). Is the problem persistent for you?

@jeffreyrosenbluth
Copy link
Member

I reinstalled all of the packages since I wanted to update for the new delayed-subtree merge and the problem went away.
@byorgey - when I build the docs under the new head, many of the arrow heads and tails are missing in the arrow tutorial?

@byorgey
Copy link
Member Author

byorgey commented Nov 14, 2013

Hmmm. Can you open a new ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants