-
Notifications
You must be signed in to change notification settings - Fork 62
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add styleFillTexture, styleLineTexture
- Loading branch information
1 parent
0924cc0
commit e2c157e
Showing
3 changed files
with
55 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e2c157e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you really mean to push this to
arrow-env
? I guess it doesn't matter if we're going to mergearrow-env
anyway.e2c157e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what to do about
styleFillColor
andstyleLineColor
yet.They do nothing in backends that support gradients.
For
fillColor
andlineColor
we were able to accommodate backendsthat did not support gradients by dumping both a
FillTexture
attributeand
FillColor
attribute into the style but that strategy may not work here.e2c157e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@byorgey I took a little liberty since they both effect arrows.
I probably should have started a new branch.
e2c157e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, no problem. I thought maybe you meant to push it directly to
master
.