-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factor out Diagrams.Solve into a package? #235
Comments
It wouldn't be onerous to separate out the code into a package, but it could be onerous to support. In particular the code in there is not based on any particular real knowledge of numerical computing. It happens to work for us so far, but I am quite sure there are lurking bugs and I am not sure I would want to encourage others to use it. On the other hand, maybe it would be a good way to get feedback and improve the code. It continues to surprise me that there is no good package for numerical root-finding on Hackage. There is http://hackage.haskell.org/package/roots but it seems abandoned, though it could certainly be revived. Our of curiosity, what would you want to use it for? |
I understand your concerns about support and correctness, although it's already public and people might already be using it, so moving it into another package would (at worst) just send the message that it's "more official" than it is now, but it'd be no more risky to use. (And it could be shipped with a disclaimer.) I looked at As for what I want to do, I'd like to use it in my ray tracer project, https://github.com/jtdaugherty/tracy. Right now I'm using |
OK, fair enough. I'd be happy to split it out. The other thing that might be nice to split out is the tridiagonal matrix solver in https://github.com/diagrams/diagrams-lib/blob/master/src/Diagrams/CubicSpline/Internal.hs. |
Thank you! |
I found myself copying |
OK, so now for the most difficult and important question: what should the On Mon, Feb 23, 2015 at 9:00 AM, Daniel Bergey notifications@github.com
|
So long as it isn't some tortured thing that starts with "h", I don't care! :) |
OK, I think I will just call it |
Everything formerly in `Diagrams.Solve` is now in `Diagrams.Solve.Polynomial` in the `diagrams-solve` package; the tridiagonal solving code in `Diagrams.CubicSpline.Internal` was moved to `Diagrams.Solve.Tridiagonal`. Closes #235.
Uploaded |
Wonderful! Thank you! I've confirmed that my ray tracer works with the new package. |
I'd really love to use
Diagrams.Solve
, but I don't want to depend ondiagrams-lib
to do it. Would you be willing to factor this module out into a separate package? It looks like a relatively self-contained module so I imagine that wouldn't be onerous.The text was updated successfully, but these errors were encountered: