Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't export Eq and Show instances for functions from Diagrams.Prelude #48

Closed
byorgey opened this issue Sep 17, 2012 · 3 comments
Closed

Don't export Eq and Show instances for functions from Diagrams.Prelude #48

byorgey opened this issue Sep 17, 2012 · 3 comments
Labels
enhancement
Milestone
0.7

Comments

@byorgey
Copy link
Member

byorgey commented Sep 17, 2012

See https://groups.google.com/forum/?fromgroups=#!topic/diagrams-discuss/c3KhwQO3L_g
@byorgey
Copy link
Member Author

byorgey commented Mar 7, 2013

Note, we shouldn't export the Num instances either!

@byorgey byorgey mentioned this issue Mar 11, 2013
Merged
byorgey pushed a commit that referenced this issue Mar 21, 2013
change Data.NumInstances import in Diagrams.TwoD.Types (see #48)
6349cf2
@amigalemming
Copy link

diagrams-core still imports vector-space, which in turn imports NumInstances.

@byorgey
Copy link
Member Author

byorgey commented Jan 19, 2014

There's nothing wrong with depending on the NumInstances package itself. The issue is specifically the Eq and Show instances for functions, which I believe that we indeed no longer export (I just tried it out). Feel free to reopen this ticket if you have an example showing otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.7
Development

No branches or pull requests
2 participants
@byorgey @amigalemming