3D scaling, alignment, coordinate lenses #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
type signatures. [ci skip]
|
No, I like the coordinate lenses. I don't think they undermine type safety any more than the existing Coordinate stuff already does. I have actually wanted something like this on several occasions (being able to project out just the x- or y-coordinates of a 2D vector or point). |
| class HasY t where | ||
| _y :: Lens' t Double | ||
|
|
||
| -- | The class of types with at least two coordinates, the third called _z. |
|
Looks good to me apart from the minor comments above. |
byorgey
added a commit
that referenced
this pull request
Oct 17, 2013
3D scaling, alignment, coordinate lenses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my last addition of 3D features before the freeze. I'll finish the CSG stuff after 1.0.
I'm not sure if the coordinate lenses in 6f82ca4 are a good idea. I modeled them after their equivalents in linear. They make writing the scaling in 62d6647 really nice. Do they undermine type safety and the distinction between points & vectors too much?