Lens #131
Merged
Lens #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| , cat, cat', CatOpts(..), CatMethod(..) | ||
| , cat, cat' | ||
| , CatOpts(..), catMethod, sep | ||
| , catOptsvProxy__ -- may not want to export? |
There was a problem hiding this comment.
Yeah, let's not export this. There's no reason to. No one should have been using it before.
|
OK, I think I've finished looking over all the changes in this pull request. If I didn't comment on something you can assume it's because I thought it looked good. |
| -- | Style to apply to the head. @headStyle@ is modified by using the lens | ||
| -- combinator @%~@ to change the current style. For example, to change | ||
| -- an opaque black arrowhead to translucent orange: | ||
| -- @(with & fc orange . opacity 0.75)@. |
There was a problem hiding this comment.
This comment needs to be fixed, should say with & headStyle %~ fc orange . opacity 0.75.
For backwards compatibility---it's something users could reasonably have been using, and it has a nice name that's unlikely to clash with anything else we want to do. Power users who want the iso can use the new Wrapped instance.
The reason for removing the catOptsProxy was that the new CatOpts lenses have restricted types, so we don't run into the problems with type inference that you get when doing record updates. However, for this release at least, we want to offer users the upgrade path of simply sticking underscores on their record labels and continuing to do record updates, so we still need the proxy, otherwise users' code will break. This reverts commit caf79c8.
See @f4285ce for an explanation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.