Image #173
Merged
Image #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| makeLenses ''Image | ||
| -- | |
| -- | An image primitive. | ||
| data DImage :: * -> * where | ||
| DImage :: ImageData t -> Int -> Int -> T2 -> DImage t | ||
| -- ^ width, height, applied transformation |
There was a problem hiding this comment.
dist/build/tmp-7144/src/Diagrams/TwoD/Image.hs:62:3:
parse error on input `-- ^ width, height, applied transformation'
Maybe you have to put this comment above DImage, using -- |?
| -- | Make a file path into a 'Diagram', i.e a primitive of type 'DImage External'. | ||
| -- This function calls @uncheckedImageRef@ and provides no guarantee that | ||
| -- the image file exists. | ||
| mkImageRef :: Renderable (DImage External) b |
There was a problem hiding this comment.
What would you say about simply getting rid of this function? Its name is uninformative, we don't particularly want to encourage its use, and it's just a simple composition of two other functions.
There was a problem hiding this comment.
That's fine with me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be merged, I'm sure there is more to do but I have implemented the API
form #29 and checked it in cairo and rasterific.
Note
Imagehas been renamedDImage- easier to work with Juicy Pixels, without constantlyqualifying imports.