-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arrow length #185
Merged
Merged
Arrow length #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like to merge this in before 1.2 for two reasons:
|
@@ -27,13 +27,13 @@ module Diagrams.TwoD.Arrow | |||
-- | |||
-- > -- Connecting two diagrams at their origins. | |||
-- > | |||
-- > sq = square 2 # showOrigin # lc darkgray # lw 0.07 | |||
-- > sq = square 2 # showOrigin # lc darkgray # lwG 0.07 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good catch. However, it would be even better if we could replace these with something like lw thick
or whatever looks right.
Should be good to go |
Looks great, thanks for putting this together @jeffreyrosenbluth ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be ready to merge.
The
headSize
andtailSize
fields have been dropped in favorof
headLength
andtailLength
, this has several advantages:lengths
traversal which can be used e.g. to make the head and tailthe same length so things like the uarrow example work.
We choose the names
headLength
andtailLength
since they areperpendicular to shaft width.
The
missile
head has been removed since it did not have a proper joint,this would be visible for translucent heads, additionally it does not
allow for the calculation of radius given length. The user can always
achieve similar results by applying a cubic spline to
dart
(which iswhat we were doing anyway).
Also the
arrowhead...
functions have been cleaned up and simplifiedconsiderably.