New loop #242
Merged
New loop #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is hopefully a more robust way to find sandboxes. It searches for the through several enrironment variable, then looks for cabal.sandbox.config in the current folder and any parents.
Make indentation consistent with the rest of the library.
Also make the output prettier.
|
Looks good to me. |
|
Looks good to me too (as far as I can tell, though I admit to not quite following all the details). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some code I wrote for the new builder. It includes a function for finding sandboxes: first it searches for environment variables, if that fails it looks for a
cabal.sandbox.configfile in the current directory and any parents. In the tests I did it seemed to work.I also cleaned up the CmdLine loop output. It now prints out all the details first and uses a single line per successful compile. I also added a lock so if you save a file twice before it compiles it won't mess everything up.
Shouldn't break any backends.