Fixed arc and arcT so they are always CCW.
#56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added a few new functions for making arcs.
| arcT :: Angle a => a -> a -> Trail R2 | ||
| arcT start end = Trail bs (sweep >= tau) | ||
| arcT start end | ||
| | e < s = arcT s (e + 1) -- Try again closer to CCW |
There was a problem hiding this comment.
Wouldn't arcT s (e + ceiling (s - e)) be better in the (admittedly rare) case when s and e differ by much more than 1?
There was a problem hiding this comment.
Yeah, I'll switch to that.
There was a problem hiding this comment.
I'm assuming there isn't some edge case with Double where e < s and ceiling (s - e) == 0.
There was a problem hiding this comment.
If there is, it serves people right for calling arcT with those arguments. I doubt such an arc would be visible anyway.
byorgey
added a commit
that referenced
this pull request
Nov 2, 2012
Fixed `arc` and `arcT` so they are always CCW.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a few new functions for making arcs. I still have to fix
roundedRect, but that should be fast once I have some tests. Wait to pull until then.