-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working on adding curvature. #74
Conversation
-- | ||
----------------------------------------------------------------------------- | ||
|
||
module Diagrams.TwoD.Curvature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be Diagrams.TwoD.Curvature
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hehe, yes. This was a consequence of not actually compiling...
For representing a scalar space extended with positive infinity we already have http://hackage.haskell.org/packages/archive/monoid-extras/0.2.2.2/doc/html/Data-Monoid-PosInf.html Hmm, though it looks like it doesn't have a |
I think most uses will want to pattern match right away, so I'm not sure a |
Is this ready to be merged? Or is there more work to do yet? |
Yeah it should be fine to merge now. If we find a good place to put the On Fri, Mar 29, 2013 at 4:54 PM, Brent Yorgey notifications@github.comwrote:
|
There are a couple of open questions with this still. One is how should we generalize the space that we compute at least the squared version. The second is what return values should we use. Would it be better to extend some scalar space with infinity explicitly?
Finally it would be nice to have this work for higher dimensions.
Also due to some failing systems here, I have not compiled this locally yet :D.