Stop exporting Diagrams.Coordinates from Diagrams.Prelude #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 9, 2013 21:05
This is for compatibility with lens, as (&) is a rather important lens operator and clashes with Coordinates. Users who want the Coordinates stuff can import Diagrams.Coordinates explicitly. Still need to update documentation to note this, and fix user manual examples, gallery, etc.
fryguybob
added a commit
that referenced
this pull request
Jun 6, 2013
Stop exporting Diagrams.Coordinates from Diagrams.Prelude
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To my knowledge there are two operator clashes between diagrams and lens: (&) and (#). (#) is fundamental to diagrams but quite peripheral to lens, so I'm happy to leave things as they are---users of diagrams+lens can hide (#) from their lens import.
With (&), the situation is reversed --- it's used heavily in idiomatic lens code, but in the context of diagrams it isn't always needed, and when it is one can just as easily use functions like
r2andp2. The proposal, therefore, is to stop re-exportingDiagrams.Coordinates(and hence (&)) fromDiagrams.Prelude. Users who want it can still importDiagrams.Coordinatesexplicitly.