Add Hashable instance for Options SVG R2 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 28, 2013 13:45
unfortunately we also have to add some orphan Hashable instances for blaze-markup types. We could contribute them back upstream to blaze-markup, but that would require adding a hashable constraint.
byorgey
added a commit
that referenced
this pull request
Jan 24, 2014
Add Hashable instance for Options SVG R2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on diagrams/diagrams-lib#146.
This pull request:
hashable > 1.1(part of the HP)blaze-markup(was already an transitive dependency viablaze-svg)DeriveGenericextension (since GHC 7.2)Hashableinstance forOptions SVG R2; needed for some pending changes/reorganization todiagrams-builder.Note that there is also an orphan
Hashableinstance forMarkupMfromblaze-markup. Perhaps we could submit it upstream toblaze-markup, but that would mean adding ahashabledependency.Note also the upper bound on
blaze-markupis too restrictive; we can loosen it in a separate commit (assuming it works fine).