Skip to content

Commit

Permalink
Merge pull request #51 from artur-ciocanu/upgrade-checkstyle
Browse files Browse the repository at this point in the history
Upgrade checkstyle to 10.17.0
  • Loading branch information
salaboy authored Jul 19, 2024
2 parents 5272771 + ea3ce09 commit 7ab29b6
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion checkstyle.xml
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@
value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/>
</module>
<module name="JavadocMethod">
<property name="scope" value="public"/>
<property name="accessModifiers" value="public"/>
<property name="allowedAnnotations" value="Override, Test"/>
</module>
<module name="MissingJavadocMethod">
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>3.3.1</version>
<version>3.4.0</version>
<configuration>
<configLocation>checkstyle.xml</configLocation>
<consoleOutput>true</consoleOutput>
Expand All @@ -118,7 +118,7 @@
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
<version>8.37</version>
<version>10.17.0</version>
</dependency>
</dependencies>
</plugin>
Expand Down
3 changes: 2 additions & 1 deletion src/test/java/io/diagrid/dapr/DaprComponentTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ public void withComponentFromPath() {
Assert.assertEquals(false, kvstore.getMetadata().isEmpty());

String componentYaml = dapr.componentToYaml(kvstore);
String expectedComponentYaml = "metadata:\n" + //
String expectedComponentYaml = "metadata:\n"
+ //
" name: statestore\n"
+ //
"apiVersion: dapr.io/v1alpha1\n"
Expand Down

0 comments on commit 7ab29b6

Please sign in to comment.