Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing cb && on set #67

Merged
merged 2 commits into from
Dec 23, 2016
Merged

Missing cb && on set #67

merged 2 commits into from
Dec 23, 2016

Conversation

sjlu
Copy link
Contributor

@sjlu sjlu commented Dec 22, 2016

Following a pattern that's used throughout the library which fixes an issue when using promises.

mrister
mrister approved these changes Dec 23, 2016
View reviewed changes
Copy link
Contributor

@mrister mrister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjlu Tnx!

@jkernech
Copy link
Contributor

Thanks for the contribution @sjlu !

@sjlu
Copy link
Contributor Author

sjlu commented Dec 23, 2016 •
edited
Loading

I also updated the test that was failing in CircleCI - funny enough the previous test was passing for the wrong reasons.

@jkernech jkernech merged commit fb836bd into dial-once:develop Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykhatal ykhatal ykhatal approved these changes

@jkernech jkernech jkernech approved these changes

@mrister mrister mrister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sjlu @jkernech @mrister @ykhatal