Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the
target
property of thewindow.open
function from_blank
to_self
.This is used in the context of actions of type
external-link
, which are supposed to open a new tab when the action button is clicked.With the current behaviour, for different browsers and browser configurations it might open a new browser window instead of a new tab. I assume this is not the intended behaviour, since the confirm popup which gets shown says that the link will open in a new tab of the browser. The
_self
target value ensures that the current browsing context is always used.target
property reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#target