Fix visual editor event copy/paste issues #2459
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salianifo
changed the title
salianifo
changed the title
|
Since I'm looking at the copy/paste features of the visual timeline, I noticed there's a few other things that need to be fixed as well, such as nested events not being nested when pasted. |
|
I noticed that when you paste into a timeline with events (but none selected), it pastes right before the last event instead of after it. This last change fixes this as well. I think the other copy/paste/move issues need discussion, and should be addressed in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2455
Closes: #2407
When pasting into an empty timeline, the paste position would be set to -1, making the first item pop down to the end of the list.