Tweak gain for ELDICO ED-1 (cctbx#732)

* Gain is not well known, so reset to 1.0
dials · Apr 30, 2024 · 2732092 · 2732092
1 parent 4b64399
commit 2732092
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/newsfragments/732.misc b/newsfragments/732.misc
@@ -0,0 +1 @@
+``FormatBrukerED1``: the gain is not well-known, so reset to 1.0 and allow the user to override at import.
diff --git a/src/dxtbx/format/FormatCBFMiniEigerQuadroED1.py b/src/dxtbx/format/FormatCBFMiniEigerQuadroED1.py
@@ -131,11 +131,12 @@ def _detector(self):
             mask=[],
         )
 
-        # Here we set specifics, notably gain=3, also parallax correction and
+        # Here we set specifics: parallax correction and
         # QE correction are effectively disabled by setting the simple
-        # pixel-to-millimetre strategy and a very high mu value.
+        # pixel-to-millimetre strategy and a very high mu value. Gain is not
+        # precisely known. We think it might be around 1.7, but here will leave
+        # as 1.0 and expect the user to override at import.
         for panel in detector:
-            panel.set_gain(3)
             panel.set_thickness(thickness)
             panel.set_material(material)
             panel.set_identifier(identifier)