Fix bug where _play() can be called twice for a single body

See c-frame#24
diarmidmackenzie · Jan 5, 2023 · 6ac5591 · 6ac5591
1 parent daf2633
commit 6ac5591
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/dist/aframe-physics-system.js b/dist/aframe-physics-system.js
@@ -16863,7 +16863,8 @@ var Body = {
     if (this.shouldUpdateBody) {
       this.isLoaded = true;
 
-      this._play();
+      this._pause()
+      this._play()
 
       this.el.emit('body-loaded', {body: this.el.body});
       this.shouldUpdateBody = false;

diff --git a/dist/aframe-physics-system.min.js b/dist/aframe-physics-system.min.js
diff --git a/src/components/body/body.js b/src/components/body/body.js
@@ -128,7 +128,11 @@ var Body = {
     if (this.shouldUpdateBody) {
       this.isLoaded = true;
 
-      this._play();
+      // pause / play will result in the object being re-added to the
+      // physics system with the updated body / shape data.
+      // pause before playing to avoid addting the body to the system twice.
+      this._pause()
+      this._play()
 
       this.el.emit('body-loaded', {body: this.el.body});
       this.shouldUpdateBody = false;