-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Housekeeping #3714
Housekeeping #3714
Conversation
Wow, this looks really great! Thanks for taking the time to help clean up this stuff! :) @MrZyx This looks good to merge; if you have no objections I'd be happy to merge this in ASAP. |
Personally, I'd prefer if we do the 0.0.2 first, and then continue the cleanup spree ;) |
This looks awesome but also should probably live in development branch for a while to notice any problems? So tend to agree with @Raven24 on this. Although I think 0.0.2 really should be 0.1.0 - it's certainly got enough stuff for a minor increment. Very far from a patch, let's not be too conservative with version numbers .. that doesn't make the project look good or attractive either. |
0.0.2.0 is a minor release, 0.1.0.0 would be major. I agree on having this for 0.0.3.0 |
@MrZyx actually no, x.y.z according to semver: X = major |
Reread the proposal you agreed to. |
AFAIK, our SemVer implementation uses release.major.minor.hotfix. I'm personally fine with that for now. Sure, our version number looks small now, but it'll move along as more helping hands join in. |
I add this to my pod to keep trying. Thanks fabianrbz |
Thank you Fabian great job ;) |
So lets see what breaks :P |
In this PR I removed a lot of views, templates and helpers that from what I've seen aren't used -as far as I've found looking into the code and some help from git grep -.