Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping #3714

Merged
merged 19 commits into from
Nov 22, 2012
Merged

Housekeeping #3714

merged 19 commits into from
Nov 22, 2012

Conversation

fabianrbz
Copy link
Contributor

In this PR I removed a lot of views, templates and helpers that from what I've seen aren't used -as far as I've found looking into the code and some help from git grep -.

@DeadSuperHero
Copy link
Member

Wow, this looks really great! Thanks for taking the time to help clean up this stuff! :)

@MrZyx This looks good to merge; if you have no objections I'd be happy to merge this in ASAP.

@Raven24
Copy link
Member

Raven24 commented Nov 8, 2012

Personally, I'd prefer if we do the 0.0.2 first, and then continue the cleanup spree ;)

@jaywink
Copy link
Contributor

jaywink commented Nov 8, 2012

This looks awesome but also should probably live in development branch for a while to notice any problems? So tend to agree with @Raven24 on this.

Although I think 0.0.2 really should be 0.1.0 - it's certainly got enough stuff for a minor increment. Very far from a patch, let's not be too conservative with version numbers .. that doesn't make the project look good or attractive either.

@jhass
Copy link
Member

jhass commented Nov 8, 2012

0.0.2.0 is a minor release, 0.1.0.0 would be major. I agree on having this for 0.0.3.0

@jaywink
Copy link
Contributor

jaywink commented Nov 8, 2012

@MrZyx actually no, x.y.z according to semver:

X = major
Y = minor
Z = patch

@jhass
Copy link
Member

jhass commented Nov 8, 2012

Reread the proposal you agreed to.

@DeadSuperHero
Copy link
Member

AFAIK, our SemVer implementation uses release.major.minor.hotfix. I'm personally fine with that for now. Sure, our version number looks small now, but it'll move along as more helping hands join in.

@movilla
Copy link
Contributor

movilla commented Nov 11, 2012

I add this to my pod to keep trying. Thanks fabianrbz

@RudyFehren
Copy link

Thank you Fabian great job ;)

@jhass
Copy link
Member

jhass commented Nov 22, 2012

So lets see what breaks :P

jhass added a commit that referenced this pull request Nov 22, 2012
@jhass jhass merged commit 5f6e03c into diaspora:develop Nov 22, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants