Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ui consts #1360

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Ui consts #1360

merged 1 commit into from
Oct 7, 2019

Conversation

AJenbo
Copy link
Member

@AJenbo AJenbo commented Aug 26, 2019 •
edited
Loading

This calculates the position of major UI panel positions, bin diff is untouched as it is done at compile time.

@AJenbo AJenbo force-pushed the ui_consts branch 2 times, most recently from ef76d3a to 1e53874 Compare August 27, 2019 13:52
@AJenbo AJenbo added the code cleanup Cosmetic enhancement to the code to make it look nicer. label Aug 30, 2019
mewmew
mewmew approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@mewmew mewmew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mewmew
Copy link
Contributor

mewmew commented Oct 7, 2019

This should help a lot with adding support for higher resolutions! great job

@mewmew mewmew merged commit 9bf8332 into master Oct 7, 2019
@AJenbo AJenbo deleted the ui_consts branch October 7, 2019 20:56
@AJenbo
Copy link
Member Author

AJenbo commented Oct 7, 2019

Thanks, glad it made some sens :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mewmew mewmew mewmew approved these changes

Assignees
No one assigned
Labels
code cleanup Cosmetic enhancement to the code to make it look nicer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AJenbo @mewmew