Give names to dword_12345678 idents #1591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mewmew
changed the title
AJenbo
reviewed
Sep 10, 2019
| @@ -37,8 +37,8 @@ BYTE *pDungeonCels; | |||
| int SpeedFrameTbl[128][16]; | |||
| THEME_LOC themeLoc[MAXTHEMES]; | |||
| char dPlayer[MAXDUNX][MAXDUNY]; | |||
| int dword_5C2FF8; | |||
| int dword_5C2FFC; | |||
| int game_world_width; | |||
There was a problem hiding this comment.
Maybe screen_chunks and screen_blocks. Since it's screen size and not world size.
There was a problem hiding this comment.
game_view_chunks, game_view_blocks
AJenbo
reviewed
Sep 11, 2019
| @@ -7,7 +7,7 @@ TMenuItem *sgpCurrItem; | |||
| BYTE *BigTGold_cel; | |||
| int PentSpin_tick; | |||
| BYTE PentSpin_frame; | |||
| void (*dword_63447C)(TMenuItem *); | |||
| void (*gmenu_enable_func)(TMenuItem *); | |||
|
Closing this PR as most variables have been given names already. The one missing is:
|
AJenbo
reviewed
Jan 3, 2021
| @@ -438,7 +438,7 @@ const char gszHelpText[] = { | |||
| void InitHelp() | |||
| { | |||
| helpflag = 0; | |||
| dword_634494 = 0; | |||
| unused_help = 0; | |||
|
Applied via a006a25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give name to gmenu_enable_func and unused_help, ...