[hellfire] ProcessMonsters bin exact #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
AJenbo
reviewed
Sep 18, 2019
|
changed ifdef |
AJenbo
reviewed
Sep 18, 2019
Source/monster.cpp
Outdated
| } | ||
| if (Monst->MType->mtype == 137) { //TODO: apply enums | ||
| if (UseCowFarmer) { | ||
| PlaySFX(997); |
There was a problem hiding this comment.
Suggested change
| PlaySFX(997); | |
| PlaySFX(USFX_NAKRUL6); |
AJenbo
reviewed
Sep 18, 2019
Source/monster.cpp
Outdated
| if (UseCowFarmer) { | ||
| PlaySFX(997); | ||
| } else { | ||
| int sound = 995; |
There was a problem hiding this comment.
Suggested change
| int sound = 995; | |
| int sound = USFX_NAKRUL4; |
AJenbo
reviewed
Sep 18, 2019
Source/monster.cpp
Outdated
| } else { | ||
| int sound = 995; | ||
| if (!IsUberRoomOpened) | ||
| sound = 996; |
There was a problem hiding this comment.
Suggested change
| sound = 996; | |
| sound = USFX_NAKRUL5; |
AJenbo
reviewed
Sep 18, 2019
Source/monster.cpp
Outdated
| } | ||
| } | ||
| if (Monst->MType->mtype == 124) | ||
| PlaySFX(989); |
There was a problem hiding this comment.
Suggested change
| PlaySFX(989); | |
| PlaySFX(USFX_DEFILER8); |
AJenbo
reviewed
Sep 18, 2019
Source/monster.cpp
Outdated
| if (Monst->MType->mtype == MT_CLEAVER) { | ||
| PlaySFX(USFX_CLEAVER); | ||
| } | ||
| if (Monst->MType->mtype == 137) { //TODO: apply enums |
There was a problem hiding this comment.
Suggested change
| if (Monst->MType->mtype == 137) { //TODO: apply enums | |
| if (Monst->MType->mtype == MT_NAKRUL) { |
enums.h line 1685
MT_NAKRUL = 0x89,
AJenbo
reviewed
Sep 18, 2019
Source/monster.cpp
Outdated
| PlaySFX(sound); | ||
| } | ||
| } | ||
| if (Monst->MType->mtype == 124) |
There was a problem hiding this comment.
Suggested change
| if (Monst->MType->mtype == 124) | |
| if (Monst->MType->mtype == MT_DEFILER) |
enums.h line 1685
MT_DEFILER = 0x7C,
AJenbo
reviewed
Sep 18, 2019
Source/monster.cpp
Outdated
| if (UseCowFarmer) { | ||
| PlaySFX(997); | ||
| } else { | ||
| int sound = 995; |
There was a problem hiding this comment.
Probably this was two calls to PlaySFX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swap to Monst->mLevel if should be merged with master