Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DIABOOL #1768

Merged
merged 3 commits into from
Oct 5, 2019
Merged

DIABOOL #1768

merged 3 commits into from
Oct 5, 2019

Conversation

qndel
Copy link
Member

@qndel qndel commented Oct 1, 2019

Does this look good? If yes, we could do the same things for BYTE->int conversion which happened in a few places in hellfire too

@qndel qndel added enhancement New feature or request help wanted Extra attention is needed Binary exact code cleanup Cosmetic enhancement to the code to make it look nicer. hellfire labels Oct 1, 2019
@qndel qndel requested a review from AJenbo October 1, 2019 18:57
AJenbo
AJenbo reviewed Oct 1, 2019
View reviewed changes
Source/doom.h Outdated Show resolved Hide resolved
AJenbo
AJenbo reviewed Oct 1, 2019
View reviewed changes
Source/doom.cpp Outdated Show resolved Hide resolved
AJenbo
AJenbo reviewed Oct 1, 2019
View reviewed changes
Source/doom.cpp Outdated Show resolved Hide resolved
AJenbo
AJenbo reviewed Oct 1, 2019
View reviewed changes
Source/items.cpp Outdated Show resolved Hide resolved
AJenbo
AJenbo approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@AJenbo AJenbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice

@qndel qndel changed the title HF_BOOL DIABOOL Oct 2, 2019
@AJenbo AJenbo merged commit 124b8a6 into diasurgical:hellfire Oct 5, 2019
@AJenbo AJenbo deleted the hellfire_boolean branch October 5, 2019 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJenbo AJenbo AJenbo approved these changes

Assignees
No one assigned
Labels
Binary exact code cleanup Cosmetic enhancement to the code to make it look nicer. enhancement New feature or request hellfire help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qndel @AJenbo