Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hellfire] GetStaffSpell #1775

Merged
merged 2 commits into from
Oct 2, 2019
Merged

[hellfire] GetStaffSpell #1775

merged 2 commits into from
Oct 2, 2019

Conversation

qndel
Copy link
Member

@qndel qndel commented Oct 2, 2019

Do we accept such a trick? :) Saves me doing an ifdef on the closing bracket

Source/items.cpp Outdated
Comment on lines 1316 to 1322
#ifdef HELLFIRE
if (0) {
#else
if (!random(17, 4)) {
GetItemPower(i, lvl >> 1, lvl, 256, onlygood);
#endif
} else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#ifdef HELLFIRE
if (0) {
#else
if (!random(17, 4)) {
GetItemPower(i, lvl >> 1, lvl, 256, onlygood);
#endif
} else {
#ifndef HELLFIRE
if (!random(17, 4)) {
GetItemPower(i, lvl >> 1, lvl, 256, onlygood);
} else
#endif
{

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github multiline comments doesn't combine with suggestions :( You will have to copy this your self.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applied

@AJenbo AJenbo merged commit 2e8e03a into diasurgical:hellfire Oct 2, 2019
@AJenbo AJenbo deleted the GetStaffSpell branch October 2, 2019 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants