Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hellfire] InitItemGFX bin exact #1986

Merged
merged 1 commit into from
Jan 20, 2020
Merged

[hellfire] InitItemGFX bin exact #1986

merged 1 commit into from
Jan 20, 2020

Conversation

qndel
Copy link
Member

@qndel qndel commented Jan 19, 2020

No description provided.

@AJenbo AJenbo mentioned this pull request Jan 19, 2020
Open
@AJenbo
Copy link
Member

AJenbo commented Jan 20, 2020

Are we going to need DINT also :(

@AJenbo AJenbo merged commit 415b175 into diasurgical:hellfire Jan 20, 2020
@AJenbo AJenbo deleted the InitItemGFX branch January 20, 2020 07:17
@ghost
Copy link

ghost commented Jan 20, 2020

This is probably because of the way the compiler generates the comparison against array count. For example, sizeof(x) / sizeof(x[0] can usually produce and unsigned comparison. So probably has to do with the wrong i < x code.

@AJenbo
Copy link
Member

AJenbo commented Jan 20, 2020

Doing so indeed fixes hellfire, but it also breaks 1.09 :/

@qndel
Copy link
Member Author

qndel commented Jan 20, 2020

we've already discussed this btw :D

@AJenbo
Copy link
Member

AJenbo commented Jan 20, 2020

Though I wouldn't see it as unrealistic that they changed it to size()/size() in case to deal with the different number of items. Changing int to uint is more pointless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Binary exact hellfire
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qndel @AJenbo