Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android release fixes #2187

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Android release fixes #2187

merged 2 commits into from
Jun 18, 2021

Conversation

AJenbo
Copy link
Member

@AJenbo AJenbo commented Jun 17, 2021

No description provided.

@AJenbo AJenbo requested a review from glebm June 17, 2021 23:51
AJenbo
AJenbo commented Jun 17, 2021
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
glebm
glebm requested changes Jun 17, 2021
View reviewed changes
Copy link
Collaborator

@glebm glebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though at this point it'd be nice to move the Android definitions to android_defs.cmake, similar to how we do this for all the other platforms.

@licaon-kter
Copy link
Contributor

While you're at it, is -DANDROID_APP_PLATFORM=android-21 really needed? I saw some warning that gradle plugin already uses platform as defined by minSDK

@AJenbo AJenbo force-pushed the android branch 3 times, most recently from ab219c6 to 2091176 Compare June 18, 2021 22:21
@AJenbo
Bump Android SDK version to 29
bfb8132 
Google now requires apps to target version 29 in order for them be be
admissable.
@AJenbo AJenbo force-pushed the android branch 2 times, most recently from 91ab72d to 60a7edb Compare June 18, 2021 22:45
@AJenbo
Fix building Android release versions
c79ab1c 
With out -03 -flto=full android builds will fail with a message that
it's not possible wiht out O1 - O3
@AJenbo
Copy link
Member Author

AJenbo commented Jun 18, 2021

While you're at it, is -DANDROID_APP_PLATFORM=android-21 really needed? I saw some warning that gradle plugin already uses platform as defined by minSDK

Looks like it isn't needed.

@AJenbo AJenbo requested a review from glebm June 18, 2021 22:51
@AJenbo AJenbo merged commit 4e6870a into master Jun 18, 2021
@AJenbo AJenbo deleted the android branch June 18, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenCWills StephenCWills StephenCWills left review comments

@glebm glebm glebm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AJenbo @licaon-kter @glebm @StephenCWills