Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kfile.check_valid_file_exists() should return silently if it's a FIFO #1147

Closed
ctb opened this issue Jul 6, 2015 · 1 comment · Fixed by #1163
Closed

kfile.check_valid_file_exists() should return silently if it's a FIFO #1147

ctb opened this issue Jul 6, 2015 · 1 comment · Fixed by #1163
Assignees
@SensibleSalmon
Labels
low-hanging-fruit

Comments

@ctb
Copy link
Member

ctb commented Jul 6, 2015

see logic in kfile.check_input_files() for example.

As it is, running normalize-by-median on a FIFO warns that the FIFO is empty.
@SensibleSalmon
Copy link
Contributor

I'll get this.

@SensibleSalmon SensibleSalmon self-assigned this Jul 9, 2015
@SensibleSalmon SensibleSalmon mentioned this issue Jul 9, 2015
Merged
8 tasks
@ctb ctb closed this as completed in #1163 Jul 17, 2015
ctb added a commit that referenced this issue Jul 17, 2015
@ctb
Merge pull request #1163 from dib-lab/fix/silent_fifo_check
283063a 
No more complaining about FIFO's being empty (addresses #1147)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SensibleSalmon SensibleSalmon

Labels
low-hanging-fruit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

No more complaining about FIFO's being empty (addresses #1147) dib-lab/khmer
2 participants
@ctb @SensibleSalmon