-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deal appropriately with --unique-kmers argument #1179
Comments
If we make it work for all scripts, this will fix #347. |
Oh, and I found a reference to args.unique_kmers in scripts/normalize-by-median.py - this should be moved into khmer_args.py, and the warning message starting with |
Note the argument optimization language should change to |
I'll get this sorted once #1170 lands. |
#1170 has landed. ;) |
Hooplah! On Tue, Jul 21, 2015 at 6:59 PM C. Titus Brown notifications@github.com
|
ping @bocajnotnef |
Yup, this is up next after I finish current stuff. On Wed, Jul 29, 2015 at 4:15 PM C. Titus Brown notifications@github.com
|
Ping wrt #1117. |
The addition of
-U/--unique-kmers
should not have applied to all scripts (see https://github.com/dib-lab/khmer/pull/1126/files#diff-2ebccdb74ba5df72b22cff1bd70d9696R63) if it was going to be ignored by all of them! We should either make it work for all scripts (which should be easy after #1050, no?) or move the parameter addition into the one bit of code that uses it onoxli/functions.py
.The text was updated successfully, but these errors were encountered: