Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal appropriately with --unique-kmers argument #1179

Closed
ctb opened this issue Jul 18, 2015 · 9 comments · Fixed by #1214
Closed

Deal appropriately with --unique-kmers argument #1179

ctb opened this issue Jul 18, 2015 · 9 comments · Fixed by #1214
Assignees
Milestone

Comments

@ctb
Copy link
Member

ctb commented Jul 18, 2015

The addition of -U/--unique-kmers should not have applied to all scripts (see https://github.com/dib-lab/khmer/pull/1126/files#diff-2ebccdb74ba5df72b22cff1bd70d9696R63) if it was going to be ignored by all of them! We should either make it work for all scripts (which should be easy after #1050, no?) or move the parameter addition into the one bit of code that uses it on oxli/functions.py.

@ctb ctb added this to the 2.0 milestone Jul 18, 2015
@ctb
Copy link
Member Author

ctb commented Jul 18, 2015

If we make it work for all scripts, this will fix #347.

@ctb
Copy link
Member Author

ctb commented Jul 19, 2015

Oh, and I found a reference to args.unique_kmers in scripts/normalize-by-median.py - this should be moved into khmer_args.py, and the warning message starting with WARNING: You are loading a saved k-mer table from... should be updated.

@ctb
Copy link
Member Author

ctb commented Jul 19, 2015

Note the argument optimization language should change to counting table size will NOT be set automatically. as per https://github.com/dib-lab/khmer/pull/1126/files#r34570761.

@SensibleSalmon
Copy link
Contributor

I'll get this sorted once #1170 lands.

@ctb
Copy link
Member Author

ctb commented Jul 21, 2015

#1170 has landed. ;)

@SensibleSalmon
Copy link
Contributor

Hooplah!

On Tue, Jul 21, 2015 at 6:59 PM C. Titus Brown notifications@github.com
wrote:

#1170 #1170 has landed. ;)


Reply to this email directly or view it on GitHub
#1179 (comment).

@ctb
Copy link
Member Author

ctb commented Jul 29, 2015

ping @bocajnotnef

@SensibleSalmon
Copy link
Contributor

Yup, this is up next after I finish current stuff.

On Wed, Jul 29, 2015 at 4:15 PM C. Titus Brown notifications@github.com
wrote:

ping @bocajnotnef https://github.com/bocajnotnef


Reply to this email directly or view it on GitHub
#1179 (comment).

@ctb
Copy link
Member Author

ctb commented Jul 29, 2015

Ping wrt #1117.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants