Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow k > 32 in khmer #60

Closed
ctb opened this issue May 22, 2013 · 7 comments
Closed

Allow k > 32 in khmer #60

ctb opened this issue May 22, 2013 · 7 comments

Comments

@ctb
Copy link
Member

ctb commented May 22, 2013

There have been a number of requests to enable k > 32 in khmer code. This should be relatively straightforward (@fishjord has a cyclic hash implementation in Java that he sent around) but has not so far been a priority. This is an issue so that we can track such requests in the future and keep it somewhere on the list.

Note, we need to figure out how to deal with _revhash issues; there are a few places in the code where exact hashes are kept and converted from numbers back into strings. Not a blocker, just a detail issue.

@mr-c
Copy link
Contributor

mr-c commented Aug 1, 2013

@fishjord where is your java implementation mentioned above?

@fishjord
Copy link
Contributor

fishjord commented Aug 1, 2013

@sjackman
Copy link

+1

@mr-c mr-c modified the milestones: 1.2+, unscheduled Sep 19, 2014
@mr-c
Copy link
Contributor

mr-c commented Jan 15, 2015

@alexjironkin
Copy link

+1

@mr-c mr-c assigned mr-c and unassigned themangoemoji Mar 12, 2015
@ctb
Copy link
Member Author

ctb commented Apr 28, 2015

@ctb
Copy link
Member Author

ctb commented Feb 16, 2017

Now enabled by #1511 and friends.

@ctb ctb closed this as completed Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants