Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine sequence format by sniffing, not by filename extension #77

Closed
ctb opened this issue Jul 7, 2013 · 5 comments
Closed

Determine sequence format by sniffing, not by filename extension #77

ctb opened this issue Jul 7, 2013 · 5 comments

Comments

@ctb
Copy link
Member

ctb commented Jul 7, 2013

FASTA/FASTQ -- this gets annoying when diginorm produces .keep files that are determined to be fasta, despite actually being fastq.

@mr-c
Copy link
Contributor

mr-c commented Jul 7, 2013

Isn't this a dupe?

@ctb
Copy link
Member Author

ctb commented Jul 7, 2013

Perhaps. Which issue? It may have crept in with the new C++ sequence
parsing. Either way, we should have tests to explicitly address.

On Sun, Jul 07, 2013 at 12:34:06AM -0700, mr-c wrote:

Isn't this a dupe?


Reply to this email directly or view it on GitHub:
#77 (comment)

C. Titus Brown, ctb@msu.edu

@mr-c
Copy link
Contributor

mr-c commented Jul 10, 2013

Issue #68 is for a standalone tool to do the same

On Sun, Jul 7, 2013 at 10:20 AM, C. Titus Brown notifications@github.comwrote:

Perhaps. Which issue? It may have crept in with the new C++ sequence
parsing. Either way, we should have tests to explicitly address.

On Sun, Jul 07, 2013 at 12:34:06AM -0700, mr-c wrote:

Isn't this a dupe?


Reply to this email directly or view it on GitHub:
#77 (comment)

C. Titus Brown, ctb@msu.edu


Reply to this email directly or view it on GitHubhttps://github.com//issues/77#issuecomment-20571316
.

@mr-c mr-c closed this as completed Dec 2, 2013
@ctb
Copy link
Member Author

ctb commented Dec 5, 2013

This seems like a largely different issue to me, no? Command line tool vs built-in library functions.

@ctb ctb reopened this Dec 5, 2013
@mr-c mr-c modified the milestones: 1.1+ Release, 1.0 release Apr 2, 2014
This was referenced Oct 29, 2014
@mr-c
Copy link
Contributor

mr-c commented Dec 15, 2014

Fixed by #642 / #643

@mr-c mr-c closed this as completed Dec 15, 2014
@mr-c mr-c modified the milestones: 1.3+, 1.3 Dec 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants