Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

khmer.ReadParser (on bleeding-edge) crashes if n_threads = 0 #86

Closed
ctb opened this issue Jul 26, 2013 · 4 comments
Closed

khmer.ReadParser (on bleeding-edge) crashes if n_threads = 0 #86

ctb opened this issue Jul 26, 2013 · 4 comments
Assignees
@ctb
Labels
bug C++ low-hanging-fruit theme:customer-oriented
Milestone
1.2 Release

Comments

@ctb
Copy link
Member

ctb commented Jul 26, 2013

Should raise an exception instead!
@ghost ghost assigned mr-c Aug 1, 2013
@mr-c mr-c mentioned this issue Mar 13, 2014
Closed
@mr-c mr-c assigned ctb and unassigned mr-c Mar 20, 2014
@mr-c
Copy link
Contributor

mr-c commented Mar 20, 2014

Assigning to @ctb as part of his exception-o-rama

@mr-c mr-c modified the milestones: 1.1+ Release, 1.0 release Apr 2, 2014
@mr-c mr-c added the C++ label Jul 17, 2014
@mr-c
Copy link
Contributor

mr-c commented Jul 17, 2014

Ping @ctb

@jiarong
Copy link
Contributor

jiarong commented Jul 23, 2014

I will work on it.
raise an python ValueError instead of C++ exception and core dump.

jiarong added a commit to jiarong/khmer that referenced this issue Jul 23, 2014
@jiarong
fixed issue dib-lab#86
1a781ed
jiarong added a commit to jiarong/khmer that referenced this issue Jul 23, 2014
@jiarong
add a test for issue dib-lab#86 in tests/test_read_parsers.py
89f7976
@jiarong jiarong mentioned this issue Jul 23, 2014
Merged
@mr-c
Copy link
Contributor

mr-c commented Aug 19, 2014

This was fixed by @jiarong in #563

@mr-c mr-c closed this as completed Aug 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctb ctb

Labels
bug C++ low-hanging-fruit theme:customer-oriented
Projects
None yet
Milestone
1.2 Release
Development

No branches or pull requests
3 participants
@ctb @jiarong @mr-c