-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix infinite loop in CountingHash gzipped IO #1043
Conversation
I'm going to add a test of this, but it will take a while to run and at least 2gb RAM. I'll use |
LGTM on a skim, but I will leave for @mr-c to merge. Note that we are in the middle of moving across the country so it may take a few weeks! |
Thanks, and good luck with the move :) |
@kdmurray91 'huge' is what 'linux' should have been named; can you rename the existing |
No longer mergable, but as you're all moving I'll only rebase to fix the conflicts when you're ready to merge, which may take some time. Ping me when you're ready, and I'll rebase immediately :) |
(We are also shifting to asking reviewers to make mergable on their own and
just merge, in cases where no other changes are needed.)
|
|
also update instructions in docs |
yo @mr-c, just let me know as soon as you need anything from me on this. Happy to implement whatever else you need. |
@kdmurray91 The worst of the merges should be done for a while. It you want to make this mergeable that'd be appreciated :-) |
235f2a5
to
fa49dc7
Compare
Good to go! |
LGTM, Thanks @kdmurray91 ! |
Fix infinite loop in CountingHash gzipped IO
Addresses #1038
Check for code coverage with
make clean diff-cover
make pep8
,make diff_pylint_report
,make cppcheck
, andmake doc
output. Usemake format
and manualfixing as needed.
without a major version increment. Changing file formats also requires a
major version number increment.
http://en.wikipedia.org/wiki/Changelog#Format
changes were made?