-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename _screed_record_dict calls in khmer #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Conflicts: ChangeLog scripts/trim-low-abund.py
Needs to wait for the next release of screed, sadly. |
OK, at this point both me and Titus touched the PR, so ready for review and merge @mr-c @camillescott |
LGTM, thanks! |
mr-c
added a commit
that referenced
this pull request
Jun 12, 2015
Rename _screed_record_dict calls in khmer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #767; taken over from #956.
Added support for changes in screed - need to have correct screed version in order to work
Passes test when specifying the screed version.
Check for code coverage with
make clean diff-cover
make pep8
,make diff_pylint_report
,make cppcheck
, andmake doc
output. Usemake format
and manualfixing as needed.
without a major version increment. Changing file formats also requires a
major version number increment.
http://en.wikipedia.org/wiki/Changelog#Format
changes were made?