Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added --force check to #1126 #1168

Merged
merged 2 commits into from
Jul 10, 2015
Merged

added --force check to #1126 #1168

merged 2 commits into from
Jul 10, 2015

Conversation

SensibleSalmon
Copy link
Contributor

see #1126 (comment)

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Is the Copyright year up to date?

@mr-c @luizirber Merge, please?

mr-c added a commit that referenced this pull request Jul 10, 2015
@mr-c mr-c merged commit 98f0680 into master Jul 10, 2015
@mr-c
Copy link
Contributor

mr-c commented Jul 10, 2015

Thanks!

@SensibleSalmon SensibleSalmon deleted the autoargs/force branch July 27, 2015 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants