Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two installation quirks #1505

Merged
merged 3 commits into from
Nov 7, 2016
Merged

Fix two installation quirks #1505

merged 3 commits into from
Nov 7, 2016

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented Nov 7, 2016

  • Quirk 1: doc/requirements.txt forced setuptools==3.4.1, which is super old and breaks installations inside Anaconda (sometimes)

  • Quirk 2: pip sometimes fails because it can't find a easy_install.pth inside the Anaconda site-packages (makes sense, no conda package should be installing it), and apparently the fix is to use the --ignore-installed flag. Source

  • Is it mergeable?

  • make test Did it pass the tests?

  • make clean diff-cover If it introduces new functionality in
    scripts/ is it tested?

  • make format diff_pylint_report cppcheck doc pydocstyle Is it well
    formatted?

  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.

  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format

  • Was a spellchecker run on the source code and documentation after
    changes were made?

  • Do the changes respect streaming IO? (Are they
    tested for streaming IO?)

  • Is the Copyright year up to date?

@luizirber
Copy link
Member Author

Ready for review and merge @standage @betatim

Copy link
Member

@standage standage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge when CI build completes.

@standage standage merged commit c114d14 into master Nov 7, 2016
@standage standage deleted the fix/conda_pip branch November 7, 2016 23:25
@betatim betatim mentioned this pull request Nov 15, 2016
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants