-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mqf integration2 #1873
base: master
Are you sure you want to change the base?
Mqf integration2 #1873
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1873 +/- ##
=========================================
- Coverage 0.07% 0.06% -0.01%
=========================================
Files 67 67
Lines 6685 7222 +537
Branches 2487 434 -2053
=========================================
Hits 5 5
- Misses 6680 7217 +537
Continue to review full report at Codecov.
|
DUUUUUUUUUDE!!!! Are those passing tests I see??? |
Yes :) I am now upgrading the mqf to the latest version and the request will be ready for merging. |
@ctb @standage @drtamermansour Have a nice day. |
hi folks, this looks ready to review - am I right? |
Yes. It should be ready to go a while ago. |
MQF, Mixed Quotient Filter, is a new variant of CQF. MQF has changed the counting scheme of the parent data structure by adding fixed size counters and using a different encoding for the dynamic one.
This improvement makes MQF more memory efficient for a wider range of Zipfian distributions. Also, MQF expanded the metadata component of the filter to enable tagging of its kmers. In addition to the basic functions provided by the original CQF, the new data structure comes with an expanding list of kmer processing functions including functions for merging and resizing the filter, functions for comparing kmer sets, and functions for indexing and meta-analysis of multiple kmer groups. More details about these functions can be found here
make clean diff-cover
or the CodeCov report that is automaticallygenerated following a successful CI build.)
changes were made?
Only backwards-compatible additions are allowed without a major version
increment. Changing file formats also requires a major version number
increment.
CHANGELOG.md
? Seekeepachangelog for more details.