Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs found by coverity #256

Merged
merged 1 commit into from
Jan 14, 2014
Merged

Bugs found by coverity #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion khmer/_khmermodule.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2194,7 +2194,8 @@ static PyObject * hash_do_subset_partition_with_abundance(PyObject * self, PyObj
PyObject_New(khmer_KSubsetPartitionObject, &khmer_KSubsetPartitionType);

if (subset_obj == NULL) {
return NULL;
delete subset_p;
return NULL;
}

subset_obj->subset = subset_p;
Expand Down
2 changes: 0 additions & 2 deletions lib/hashbits.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ namespace khmer {
}
}

uint32_t _all_tags_spin_lock;

public:
Hashbits(WordLength ksize, std::vector<HashIntoType>& tablesizes)
: khmer::Hashtable(ksize),
Expand Down
4 changes: 2 additions & 2 deletions lib/labelhash.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,10 +220,10 @@ void LabelHash::consume_sequence_and_tag_with_labels(const std::string& seq,
while(!kmers.done()) {
kmer = kmers.next();

if ((is_new_kmer = test_and_set_bits( kmer )))
if ((is_new_kmer = test_and_set_bits( kmer ))) {
++n_consumed;
printdbg(test_and_set_bits)

}
#if (1)
if (is_new_kmer) {
printdbg(new kmer...)
Expand Down