Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: make-initial-stoptags.py error on missing .ht input file, actual input file is .pt #391

Merged
merged 1 commit into from
Apr 19, 2014

Conversation

RamRS
Copy link
Contributor

@RamRS RamRS commented Apr 17, 2014

No description provided.

@ged-jenkins
Copy link

Can one of the admins verify this patch?

@ctb
Copy link
Member

ctb commented Apr 18, 2014

jenkins, test this please

@ctb
Copy link
Member

ctb commented Apr 18, 2014

test this please

@ged-jenkins
Copy link

Test PASSed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/484/

@ged-jenkins
Copy link

Test PASSed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/485/

@RamRS
Copy link
Contributor Author

RamRS commented Apr 18, 2014

I checked, ".ht" file verification does not exist in any other script. We should be good to go. Also, Emeric confirmed that the temp fix from yesterday solved the issue he faced.

@mr-c
Copy link
Contributor

mr-c commented Apr 18, 2014

Don't forget the ChangeLog entry
On Apr 17, 2014 8:53 PM, "Ram RS" notifications@github.com wrote:

I checked, ".ht" file verification does not exist in any other script. We
should be good to go. Also, Emeric confirmed that the temp fix from
yesterday solved the issue he faced.


Reply to this email directly or view it on GitHubhttps://github.com//pull/391#issuecomment-40778326
.

@RamRS
Copy link
Contributor Author

RamRS commented Apr 18, 2014

Done + squashed to single commit. PS: I ran make test, make pep8 and make pylint, so tests should be OK.

@mr-c
Copy link
Contributor

mr-c commented Apr 19, 2014

  • Is it mergable
  • Did it pass the tests?
  • n/a If it introduces new functionality in scripts/ is it tested?
    Check for code coverage.
  • Is it well formatted? Look at pep8/pylint, cppcheck, and
    make doc output. Use autopep8 and astyle -A10 if needed.
  • Is it documented in the Changelog?

@mr-c
Copy link
Contributor

mr-c commented Apr 19, 2014

Fixes #381

mr-c added a commit that referenced this pull request Apr 19, 2014
Bug fix: make-initial-stoptags.py error on missing .ht input file, actual input file is .pt
@mr-c mr-c merged commit f5428c5 into dib-lab:master Apr 19, 2014
@RamRS RamRS deleted the bugfix-htpt branch April 19, 2014 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants