Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated diginorm for new FP rate info; corrected spelling error #398

Merged
merged 1 commit into from
May 7, 2014
Merged

updated diginorm for new FP rate info; corrected spelling error #398

merged 1 commit into from
May 7, 2014

Conversation

ctb
Copy link
Member

@ctb ctb commented Apr 21, 2014

  • Is it mergable
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage.
  • Is it well formatted? Look at pep8/pylint, cppcheck, and
    make doc output. Use autopep8 and astyle -A10 if needed.
  • Is it documented in the Changelog?
  • Was spellcheck run on the source code and documentation after changes were made?

@ctb
Copy link
Member Author

ctb commented Apr 21, 2014

Need to look at code coverage; if there is no current coverage for FP rate checking, we should create an issue to add it. But, either way, not needed to merge this, IMO.

@ged-jenkins
Copy link

Test PASSed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/489/

@ctb
Copy link
Member Author

ctb commented Apr 21, 2014

Ready for review.

@mr-c
Copy link
Contributor

mr-c commented Apr 22, 2014

Issue #402 has been created to track the testing gap.

@mr-c
Copy link
Contributor

mr-c commented Apr 22, 2014

retest this please

@mr-c mr-c added this to the v1.0.1 milestone Apr 25, 2014
This was referenced Apr 25, 2014
Closed
Closed
@ctb
Copy link
Member Author

ctb commented May 7, 2014

OK, ready for merge, I think. @mr-c

mr-c added a commit that referenced this pull request May 7, 2014
@mr-c
Merge pull request #398 from ged-lab/feature/update_fp_rate
66a56ba 
updated diginorm for new FP rate info; corrected spelling error
@mr-c mr-c merged commit 66a56ba into master May 7, 2014
@mr-c mr-c deleted the feature/update_fp_rate branch May 7, 2014 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ctb @ged-jenkins @mr-c