Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always run zlib's configure; CFLAGS may have changed #453

Merged
merged 1 commit into from
Jun 9, 2014

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Jun 4, 2014

For @ctb, fixes #442

@mr-c
Copy link
Contributor Author

mr-c commented Jun 4, 2014

  • Is it mergable
  • Did it pass the tests?
  • N/A If it introduces new functionality in scripts/ is it tested?
    Check for code coverage.
  • Is it well formatted? Look at pep8/pylint, cppcheck, and
    make doc output. Use autopep8 and astyle -A10 --max-code-length=80
    if needed.
  • Is it documented in the Changelog?
  • N/A Was spellcheck run on the source code and documentation after changes
    were made?

@mr-c
Copy link
Contributor Author

mr-c commented Jun 4, 2014

Ready for merging @ctb

@ctb
Copy link
Member

ctb commented Jun 5, 2014

'make' now always recompiles everything, which is suboptimal... can fix?

@ctb
Copy link
Member

ctb commented Jun 5, 2014

Another fix might be to have 'make clean' properly reset things so that configure is run on the next build, no?

@mr-c
Copy link
Contributor Author

mr-c commented Jun 9, 2014

It only recompiles zlib & bzip2; I use ccache and I barely notice a slowdown. I can look into why the 'clean' target is insufficient

@ctb
Copy link
Member

ctb commented Jun 9, 2014

On Mon, Jun 09, 2014 at 08:50:48AM -0700, Michael R. Crusoe wrote:

It only recompiles zlib & bzip2; I use ccache and I barely notice a slowdown. I can look into why the 'clean' target is insufficient

please do. Extra compilation steps bug people who work on laptops when
no power is available :)

@mr-c
Copy link
Contributor Author

mr-c commented Jun 9, 2014

distclean is sufficient according to my tests, I redid the PR.

@mr-c
Copy link
Contributor Author

mr-c commented Jun 9, 2014

Merging as it passes the tests and is minimal.

mr-c added a commit that referenced this pull request Jun 9, 2014
always run zlib's configure; CFLAGS may have changed
@mr-c mr-c merged commit 27650d4 into master Jun 9, 2014
@mr-c mr-c deleted the fix/zlib-config-reset branch June 9, 2014 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

execution of latest master fails on athyra
2 participants