Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed load-into-hashbits from sandbox & ChangeLog #480

Merged
merged 2 commits into from
Jun 15, 2014

Conversation

themangoemoji
Copy link
Contributor

update. It is superseded by load-graph in scripts.

update. It is superseded by load-graph in scripts.
@themangoemoji
Copy link
Contributor Author

should I add description into the epilogue for load-graph? @mr-c

2014-06-12 Michael Wright <wrigh517@msu.edu>

* sandbox/load-into-hashbits: Deleted from sandbox. It is superseded
by load-graph.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly. It is superceded by load-graph.py --no-tagset

@mr-c
Copy link
Contributor

mr-c commented Jun 12, 2014

It is an open question as to where replacements for scripts that used to be in sandbox/ go. @ctb?

@ctb
Copy link
Member

ctb commented Jun 15, 2014

I don't understand the question about where sandbox scripts go :).

@wrightmhw, I'll fix ChangeLog and merge.

ctb added a commit that referenced this pull request Jun 15, 2014
Removed load-into-hashbits from sandbox & ChangeLog
@ctb ctb merged commit 79273a2 into master Jun 15, 2014
@ctb ctb deleted the fix/load-into-hashbits branch June 15, 2014 11:11
@mr-c
Copy link
Contributor

mr-c commented Jun 15, 2014

The question was about where to document removals or migrations from
sandbox/.
On Jun 15, 2014 7:10 AM, "C. Titus Brown" notifications@github.com wrote:

I don't understand the question about where sandbox scripts go :).

@wrightmhw https://github.com/wrightmhw, I'll fix Changelog and merge.


Reply to this email directly or view it on GitHub
#480 (comment).

@ctb
Copy link
Member

ctb commented Jun 16, 2014

On Sun, Jun 15, 2014 at 02:23:23PM -0700, Michael R. Crusoe wrote:

The question was about where to document removals or migrations from
sandbox/.

OK. I think ChangeLog is probably good enough, no? Or the release notes?
It just needs to be googleable.

--t

@mr-c
Copy link
Contributor

mr-c commented Jun 16, 2014

Both, I'd say.

@ctb
Copy link
Member

ctb commented Jun 16, 2014

+1 to both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants