Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated extract-long sequence to extract 200 bp sequences by default #486

Merged
merged 4 commits into from
Jun 15, 2014

Conversation

ctb
Copy link
Member

@ctb ctb commented Jun 14, 2014

See #461 and #477.

@ctb
Copy link
Member Author

ctb commented Jun 14, 2014

  • Is it mergable
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage.
  • Is it well formatted? Look at pep8/pylint, cppcheck, and
    make doc output. Use autopep8 and astyle -A10 --max-code-length=80
    if needed.
  • Is it documented in the Changelog?
  • Was spellcheck run on the source code and documentation after changes
    were made?

@ctb
Copy link
Member Author

ctb commented Jun 14, 2014

Ready for review @mr-c @wrightmhw.

@@ -3,9 +3,15 @@
* Makefile: split coverity target in two: -build and -upload. Added
configuration target

2014-06-13 Titus Brown <t@Titus-MacBook-Air-2.local>
2014-06-14 Titus Brown <t@idyll.org>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2014/6/14 entries should come before 2014/6/13 in a Changelog

@mr-c
Copy link
Contributor

mr-c commented Jun 15, 2014

LGTM; Fix the changelog and I'll merge.

@ctb
Copy link
Member Author

ctb commented Jun 15, 2014

Merging!

ctb added a commit that referenced this pull request Jun 15, 2014
updated extract-long sequence to extract 200 bp sequences by default
@ctb ctb merged commit 4ed69ea into master Jun 15, 2014
@ctb ctb deleted the update/extract-long-seqs branch June 15, 2014 10:45
@mr-c mr-c added this to the v1.1 milestone Sep 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants