Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fix to normalize-by-median, cleanup of saturate #586

Merged
merged 2 commits into from
Aug 29, 2014

Conversation

ctb
Copy link
Member

@ctb ctb commented Aug 28, 2014

A few minor issues; note that saturate-by-median is in sandbox and so doesn't need to be reviewed particularly.

@ctb
Copy link
Member Author

ctb commented Aug 28, 2014

  • Is it mergable
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage.
  • Is it well formatted? Look at pep8/pylint, cppcheck, and
    make doc output. Use autopep8 and astyle -A10 --max-code-length=80
    if needed.
  • Is it documented in the Changelog?
  • Was spellcheck run on the source code and documentation after changes
    were made?

@ctb
Copy link
Member Author

ctb commented Aug 28, 2014

I think this is ready for review. Anyone?

@mr-c mr-c added the bug label Aug 29, 2014
@mr-c mr-c added this to the 1.2 Release milestone Aug 29, 2014
mr-c added a commit that referenced this pull request Aug 29, 2014
minor fix to normalize-by-median, cleanup of saturate
@mr-c mr-c merged commit b7e53c9 into master Aug 29, 2014
@mr-c mr-c deleted the cleanup/normalize_and_saturate branch August 29, 2014 08:56
@mr-c
Copy link
Contributor

mr-c commented Aug 29, 2014

LGTM, merged

@ctb
Copy link
Member Author

ctb commented Aug 29, 2014

excellent, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants