Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a ReadTheDocs badge #687

Merged
merged 5 commits into from
Apr 7, 2015
Merged

add a ReadTheDocs badge #687

merged 5 commits into from
Apr 7, 2015

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Dec 11, 2014

No description provided.

@ctb
Copy link
Member

ctb commented Dec 14, 2014

The doc badge says 'latest', and not 1.2? Is that correct?

@mr-c
Copy link
Contributor Author

mr-c commented Dec 14, 2014

We can add a version'd badge but then that URL will need to be updated with each release.

example: Documentation Status

@mr-c
Copy link
Contributor Author

mr-c commented Dec 30, 2014

@ctb Shall I go for a versioned badge or drop this?

@ctb
Copy link
Member

ctb commented Dec 31, 2014

Up to you. You're usually even more precise about these things than me ;)

@ctb
Copy link
Member

ctb commented Jan 27, 2015

Shall I merge?

@mr-c
Copy link
Contributor Author

mr-c commented Jan 27, 2015

Sure

On Tue Jan 27 2015 at 1:14:53 PM C. Titus Brown notifications@github.com
wrote:

Shall I merge?

—
Reply to this email directly or view it on GitHub
#687 (comment).

@ctb
Copy link
Member

ctb commented Jan 28, 2015

Made mergeable; pls go ahead and merge when tests pass.

@ctb
Copy link
Member

ctb commented Jan 28, 2015

(Trying to stick with the idea that, barring a release-time exception, the last person to make a chance doesn't get to merge it. :)

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 50aa2bf on ged-lab:feature/rtd-badge into d4621d3 on ged-lab:master.

@SensibleSalmon
Copy link
Contributor

@mr-c Should be mergable

mr-c
mr-c reviewed Apr 7, 2015
View reviewed changes
ChangeLog
@@ -377,6 +381,7 @@
* khmer/_khmermodule.cc: added functions hash_find_all_tags_list and
hash_get_tags_and_positions to CountingHash objects.
* tests/test_counting_hash.py: added tests for new functionality.
>>>>>>> 43c03839ebd8d8f8ff110f5a9450f4eacbce0b9e
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bocajnotnef ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh. I always miss merge markers.

@SensibleSalmon
Copy link
Contributor

retest this please

@SensibleSalmon
Copy link
Contributor

@mr-c I fixed it. :<

mr-c added a commit that referenced this pull request Apr 7, 2015
@mr-c
Merge pull request #687 from ged-lab/feature/rtd-badge
05c72a5 
add a ReadTheDocs badge
@mr-c mr-c merged commit 05c72a5 into master Apr 7, 2015
@mr-c mr-c deleted the feature/rtd-badge branch April 7, 2015 21:24
@mr-c
Copy link
Contributor Author

mr-c commented Apr 7, 2015

Thanks @bocajnotnef !

@SensibleSalmon
Copy link
Contributor

Of course!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mr-c @ctb @landscape-bot @SensibleSalmon