-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to PR checklist in CONTRIBUTING.md #753
Conversation
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
jenkins, ok to test |
Awesome, thanks @PamelaM ! |
Add link to PR checklist in CONTRIBUTING.md
@PamelaM, Congratulations on your first commit to the khmer project! Your name will be included in the release notes for the next version and you'll be listed amongst our other contributors in the next software release paper. |
Seems like a lot of credit for a non-code change :) but thanks pam On Tue, Feb 3, 2015 at 4:59 PM, Michael R. Crusoe notifications@github.com
Pamela McA'Nulty Follow Addgene on Facebook https://www.facebook.com/addgene, Twitter |
That's how we roll :-) On Tue Feb 03 2015 at 11:01:06 PM PamelaM notifications@github.com wrote:
|
Since github adds the link to CONTRIBUTING.md when creating pull requests, I thought that the CONTRIBUTING.md should call out the checklist specifically. An even cooler approach would be to modularize the text of the checklist block and include it in CONTRIBUTING.md and the docs, but my docs build foo isn't there yet.
Check for code coverage.
make pep8
,make diff_pylint_report
,make cppcheck
, andmake doc
output. Usemake format
and manualfixing as needed.
without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?