Implemented rustic CLI for the makefile #783
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Jenkins, add to testlist |
|
Thanks Daniel, reviewing now. |
|
|
||
| ## all : default task; show list of build commands | ||
| all: commands |
There was a problem hiding this comment.
This breaks make from compiling the code which is the number one expectation I have of a Makefile :-)
| commands: Makefile | ||
| @sed -n 's/^##//p' $< | ||
|
|
||
| ## install-dependencies : use pip to install Python module dependencies |
There was a problem hiding this comment.
'install most of the development dependencies via pip'
|
Jenkins, test this please |
| cppcheck: $(CPPSOURCES) | ||
| ${CPPCHECK} | ||
|
|
||
| ## pep8 : run static analysis on Python code |
There was a problem hiding this comment.
static analysis is a bit strong here; pep8 just enforces the style guide. pylint comes closer to static analysis
|
Jenkins, test this please |
|
That should do it, assuming this build passes. |
| @@ -1,3 +1,8 @@ | |||
| 2015-02-19 Daniel Standage <daniel.standage@gmail.com> | |||
|
|
|||
| * Makefile: adjust default build target (`all`) to print out a list of | |||
There was a problem hiding this comment.
This statement is no longer true
|
Jenkins, test this please |
|
Now I'm getting pep8 failures unrelated to the changes I made :( |
|
Flummoxed. No pep8 errors on my MBP, Jenkins is still complaining. |
|
Jenkins, test this please |
|
Ready to merge |
|
Very slick, thanks @standage ! |
Implemented rustic CLI for the makefile
Resolves #775, although I admit I had to guess regarding a couple of the targets.
Let me know if I got anything wrong.
Check for code coverage with
make clean diff-covermake pep8,make diff_pylint_report,make cppcheck, andmake docoutput. Usemake formatand manualfixing as needed.
without a major version increment. Changing file formats also requires a
major version number increment.
http://en.wikipedia.org/wiki/Changelog#Format
changes were made?