Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected spelling errors in doc/dev/coding-guidelines-and-review.txt #804

Merged
merged 3 commits into from
Feb 20, 2015

Conversation

aditi9783
Copy link
Contributor

Fixed spellings in doc/dev/coding-guidelines-and-review.txt. Fixes issue #801.

  • Is it mergable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ged-jenkins
Copy link

Can one of the admins verify this patch?

1 similar comment
@ged-jenkins
Copy link

Can one of the admins verify this patch?

@ctb
Copy link
Member

ctb commented Feb 20, 2015

jenkins ok to test

@ctb
Copy link
Member

ctb commented Feb 20, 2015

jenkins add to test list

@aditi9783
Copy link
Contributor Author

Ready to review!

@mr-c
Copy link
Contributor

mr-c commented Feb 20, 2015

Jenkins, test this please

@aditi9783
Copy link
Contributor Author

Ready to review.

@ctb
Copy link
Member

ctb commented Feb 20, 2015

LGTM - thanks!

ctb added a commit that referenced this pull request Feb 20, 2015
Corrected spelling errors in doc/dev/coding-guidelines-and-review.txt
@ctb ctb merged commit c166f71 into dib-lab:master Feb 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants