-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fastq-to-fasta.py #814
Conversation
Changed '-n' default description to match behaviour
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
Jenkins, add to testlist |
Thanks, @ACharbonneau ! Can you paste the checklist from http://khmer.readthedocs.org/en/latest/dev/coding-guidelines-and-review.html#checklist ? |
ping @ACharbonneau |
|
ping @ACharbonneau |
Hey, So this was only a change to the comments & help, so the description matches what the script actually does; which presumably means it will pass all the tests. However, I cannot get tests to run correctly on my machine. See: #1156 (comment) If you guys don't want to merge it in without tests, I can close the pull request and let someone else fix it, or I'll finish the tests as soon as we get my computer to run them. Sorry :( |
Let's keep this open; @bocajnotnef will polish it for you. Thank you for On Wed, Jul 29, 2015, 08:28 Amanda Charbonneau notifications@github.com
|
"Merged" #814--Thanks @ACharbonneau! |
Changed '-n' default description to match behaviour