Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend shebang line in sandbox scripts for python2 #815

Merged
merged 2 commits into from
Feb 21, 2015

Conversation

Echelon9
Copy link
Contributor

Resolves Issue #794

  • Is it mergable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage.
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ged-jenkins
Copy link

Can one of the admins verify this patch?

1 similar comment
@ged-jenkins
Copy link

Can one of the admins verify this patch?

@Echelon9
Copy link
Contributor Author

Ready for review


* sandbox/{calc-best-assembly,calc-error-profile,normalize-by-align,
read_aligner,slice-reads-by-coverage}.py: reference /usr/bin/env python2
in the shebang line.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'in the #! line.' please, thanks!

@Echelon9
Copy link
Contributor Author

PR amended per feedback from @mr-c

mr-c added a commit that referenced this pull request Feb 21, 2015
Amend shebang line in sandbox scripts for python2
@mr-c mr-c merged commit 3150625 into dib-lab:master Feb 21, 2015
@mr-c
Copy link
Contributor

mr-c commented Feb 21, 2015

Thanks!

@Echelon9 Echelon9 deleted the fix/issue_794 branch February 21, 2015 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants